Merged
Conversation
Remove experimental note on options to make the MetricKit integration GA. Fixes GH-2585
Contributor
|
Codecov Report
@@ Coverage Diff @@
## main #3340 +/- ##
=============================================
+ Coverage 89.252% 89.316% +0.063%
=============================================
Files 502 502
Lines 54488 54485 -3
Branches 19570 19566 -4
=============================================
+ Hits 48632 48664 +32
+ Misses 4987 4958 -29
+ Partials 869 863 -6 see 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 005bb4c | 1237.38 ms | 1255.54 ms | 18.16 ms |
| d257eb9 | 1206.98 ms | 1227.50 ms | 20.52 ms |
| fb53d97 | 1226.08 ms | 1245.12 ms | 19.04 ms |
| 60dd0f5 | 1238.98 ms | 1254.48 ms | 15.50 ms |
| fd6a31c | 1190.43 ms | 1218.78 ms | 28.35 ms |
| d40512b | 1231.12 ms | 1244.54 ms | 13.42 ms |
| 5616e0a | 1224.12 ms | 1249.86 ms | 25.74 ms |
| fc163f5 | 1219.18 ms | 1242.74 ms | 23.56 ms |
| 25737cb | 1235.02 ms | 1250.06 ms | 15.04 ms |
| 4fc7fdf | 1236.69 ms | 1242.80 ms | 6.11 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 005bb4c | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| d257eb9 | 20.76 KiB | 433.22 KiB | 412.46 KiB |
| fb53d97 | 20.76 KiB | 425.81 KiB | 405.04 KiB |
| 60dd0f5 | 20.76 KiB | 393.37 KiB | 372.61 KiB |
| fd6a31c | 20.76 KiB | 436.50 KiB | 415.74 KiB |
| d40512b | 20.76 KiB | 427.77 KiB | 407.00 KiB |
| 5616e0a | 22.85 KiB | 407.44 KiB | 384.59 KiB |
| fc163f5 | 20.76 KiB | 436.29 KiB | 415.53 KiB |
| 25737cb | 20.76 KiB | 436.29 KiB | 415.53 KiB |
| 4fc7fdf | 20.76 KiB | 436.25 KiB | 415.49 KiB |
brustolin
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Remove experimental note on options to make the MetricKit integration GA.
💡 Motivation and Context
Fixes GH-2585
💚 How did you test it?
Nothing to test for removing code comments.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps